fix facet support #100
Merged
fix facet support #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to see what Super Search is returning in the response payload.
This changes the basic supersearchfacet mode to support multiple facets.
So you can now do:
supersearchfacet --_facets=product --_facets=platform \
--_facets=release_channel
And it'll do one Super Search API query and print the information for
each facet in a separate group.
This also adds a "raw" format which prints the HTTP response without
doing anything to it.
This fixes support for cardinality. For example, this now works:
supersearchfacet --product=Firefox --_facets=_cardinality.build_id
willkg
commented
Oct 10, 2023
|
|
||
| # If it is in count/period mode, then we have to do one facet for each | ||
| # period and compose the results. | ||
| if "signature" not in params["_facets"] and "signature" in facet_data_payload["facets"]: |
There was a problem hiding this comment.
We should fix this in Crash Stats, but I'm not sure why Crash Stats does this and what might rely on it because it's been this way for years.
willkg
commented
Oct 10, 2023
|
|
||
| # Figure out what facet we're doing | ||
| facet_name = params["_facets"][0] | ||
| if format_type == "raw": |
There was a problem hiding this comment.
Between this format and --verbose, you get a great idea of what the HTTP request and response look like.
willkg
commented
Oct 10, 2023
|
|
||
| for day_start, day_end in generate_periods(period, start_date, end_date): |
There was a problem hiding this comment.
I can get rid of generate_periods, too.
Previously, we had our own implementation of histograms allowing us to look at values over time. This reworks supersearchfacet to use Super Search API _histogram and _histogram_interval to do the same thing, but with a single Super Search API call.
willkg
commented
Oct 11, 2023
| facets = facet_data["facets"] | ||
| if format_type == "json": | ||
| console.print_json(json.dumps(facet_tables)) | ||
| continue |
There was a problem hiding this comment.
For JSON format, it's better to print the whole thing rather than break it up into fields, so we do that here. Further, we probably don't want the blank line between items.
willkg
commented
Oct 11, 2023
| :returns: a map of facet_name -> {headers: headers, records: records} | ||
|
|
||
| """ | ||
| # FIXME(willkg): add support for nested aggregations |
There was a problem hiding this comment.
Also need to add support for cardinality values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_histogramsupport (support _histogram in super search api #98)Fixes #99
Fixes #98