Ads team ppa testing (fix #14839) #14850
Draft
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14850 +/- ##
=======================================
Coverage 77.37% 77.38%
=======================================
Files 161 161
Lines 8302 8305 +3
=======================================
+ Hits 6424 6427 +3
Misses 1878 1878 ☔ View full report in Codecov by Sentry. |
craigcook
requested changes
Jul 19, 2024
|
|
||
| link.addEventListener('click', () => { | ||
| navigator.privateAttribution.measureConversion({ | ||
| task: 'task_id', // Unique task ID. Supplied by Mozilla. |
There was a problem hiding this comment.
Has this been provided yet? I assume our unique task ID is not actually task_id.
There was a problem hiding this comment.
Both task and histogramSize have not been provided yet. I will update the PR once they are available
alexgibson
reviewed
Jul 22, 2024
| 'use strict'; | ||
|
|
||
| link.addEventListener('click', () => { | ||
| navigator.privateAttribution.measureConversion({ |
There was a problem hiding this comment.
Will this throw an error in older Firefox versions? It might be worth wrapping in a try/catch if so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Significant changes and points to review
Issue / Bugzilla link
#14839
Testing