-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup CTD landing & update promo link #14965
base: main
Are you sure you want to change the base?
Conversation
<p><small>(Wir haben auch ein paar wirklich gute Argumente.)</small></p> | ||
|
||
<a href="{{ url('firefox') }}" class="mzp-c-button mzp-t-product" data-cta-text="Ich schau mir Firefox mal an" data-cta-type="button" data-cta-position="banner">Ich schau mir Firefox mal an</a> | ||
<a href="/de/firefox/challenge-the-default/" class="mzp-c-button mzp-t-product" data-cta-text="Ich schau mir Firefox mal an" data-cta-type="button" data-cta-position="banner">Ich schau mir Firefox mal an</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a /de/–only promo include with hardcoded de strings, so I felt it's okay to also hardcode a /de/* link, given it's not available in the defined url()s otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW the only thing I have left as-is is the switch logic that still implies the original /firefox takeover:
bedrock/bedrock/firefox/templates/firefox/challenge-the-default/landing-switch.html
Line 20 in 36e8e9c
{% include 'firefox/index.html' %} |
which results in missing strings if the campaign is turned off, and the landing not removed and/or redirected away (see e.g. https://www.allizom.org/de/firefox/challenge-the-default/ …)
I contemplated monkey-patching a meta-redirect instead of said include, but the page should be removed or redirected from when the time comes instead of flipping the switch anyways now when it's not /firefox takeover, so I kept it as-is — maybe the switch logic can be removed completely to be on the safe side?
<td class="safari"></td> | ||
<td class="chrome"></td> | ||
<td class="edge"></td> | ||
</tr> | ||
<tr> | ||
<th scope="row">{{ compare_privacy }}</th> | ||
<td class="firefox" aria-label="checkmark">✓</td> | ||
<td class="firefox" aria-label="checkmark">✓</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: would it be worth to fix #13357 by replacing these with some more plain ASCII like •
bullet?
Needs a rebase 🙏 |
(I cowardly did a merge instead to better show the diff, it should only be tabindex additions and data-cta-type removals from the recently landed PRs.) |
One-line summary
Fixes link from /de home leading to CTD landing. (Also fixes random markup issues.)
Significant changes and points to review
The CTD was created in several phases and lived in a few places before settling where it is today, accumulating some fragments of its history that break things today. This aims to make it all work as expected:
Landing changed to fx base and cleaned up to just extend from base. Fixed:
Also fixed:
Issue / Bugzilla link
#14957
#14950
Testing
http://localhost:8000/de/
http://localhost:8000/de/firefox/challenge-the-default/
http://localhost:8000/fr/firefox/challenge-the-default/?v=6
http://localhost:8000/pl/firefox/challenge-the-default/