Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup CTD landing & update promo link #14965

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Aug 13, 2024

One-line summary

Fixes link from /de home leading to CTD landing. (Also fixes random markup issues.)

Significant changes and points to review

The CTD was created in several phases and lived in a few places before settling where it is today, accumulating some fragments of its history that break things today. This aims to make it all work as expected:

Landing changed to fx base and cleaned up to just extend from base. Fixed:

  • missing title/suffix whitespace,
  • meta whitespace/newlines breaking some social previews,
  • removed social image definition to enable the locale includes provide that.

Also fixed:

  • Missing v6 heading in /fr shimmed with control (if you have the correct string feel free to suggest…)
  • Some unclosed tags fixed by moving things around, some extra closing tags removed.
  • Repetitive id on presentational elements fixed by adding size grouping in the id.
  • Mobile markup rendering as text being sanitised marked as safe.
  • Style imports were reordered for all the components to have the necessary variables defined, and anything unused removed.
  • Added cursor: pointer to details summary.

Issue / Bugzilla link

#14957
#14950

Testing

http://localhost:8000/de/
http://localhost:8000/de/firefox/challenge-the-default/
http://localhost:8000/fr/firefox/challenge-the-default/?v=6
http://localhost:8000/pl/firefox/challenge-the-default/

@janbrasna janbrasna marked this pull request as ready for review August 21, 2024 07:02
Comment on lines 36 to 38
<p><small>(Wir haben auch ein paar wirklich gute Argumente.)</small></p>

<a href="{{ url('firefox') }}" class="mzp-c-button mzp-t-product" data-cta-text="Ich schau mir Firefox mal an" data-cta-type="button" data-cta-position="banner">Ich schau mir Firefox mal an</a>
<a href="/de/firefox/challenge-the-default/" class="mzp-c-button mzp-t-product" data-cta-text="Ich schau mir Firefox mal an" data-cta-type="button" data-cta-position="banner">Ich schau mir Firefox mal an</a>
Copy link
Contributor Author

@janbrasna janbrasna Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a /de/–only promo include with hardcoded de strings, so I felt it's okay to also hardcode a /de/* link, given it's not available in the defined url()s otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW the only thing I have left as-is is the switch logic that still implies the original /firefox takeover:

which results in missing strings if the campaign is turned off, and the landing not removed and/or redirected away (see e.g. https://www.allizom.org/de/firefox/challenge-the-default/ …)

I contemplated monkey-patching a meta-redirect instead of said include, but the page should be removed or redirected from when the time comes instead of flipping the switch anyways now when it's not /firefox takeover, so I kept it as-is — maybe the switch logic can be removed completely to be on the safe side?

<td class="safari"></td>
<td class="chrome"></td>
<td class="edge"></td>
</tr>
<tr>
<th scope="row">{{ compare_privacy }}</th>
<td class="firefox" aria-label="checkmark">&#x2713;</td>
<td class="firefox" aria-label="checkmark"></td>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: would it be worth to fix #13357 by replacing these with some more plain ASCII like bullet?

@stephaniehobson stephaniehobson added Needs Review Awaiting code review Frontend HTML, CSS, JS... client side stuff P3 Third level priority - Nice to have labels Aug 27, 2024
@janbrasna janbrasna changed the title Fix CTD promo & simplify landing Fixup CTD landing & update promo link Sep 28, 2024
@stephaniehobson
Copy link
Contributor

Needs a rebase 🙏

@janbrasna
Copy link
Contributor Author

(I cowardly did a merge instead to better show the diff, it should only be tabindex additions and data-cta-type removals from the recently landed PRs.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review P3 Third level priority - Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants