Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3579: Welcome email cta button string update #4093

Merged
merged 1 commit into from
Nov 28, 2023
Merged

MPP-3579: Welcome email cta button string update #4093

merged 1 commit into from
Nov 28, 2023

Conversation

rafeerahman
Copy link
Contributor

@rafeerahman rafeerahman commented Nov 9, 2023

This PR fixes MPP-3579.

New feature description

String has changed to "Learn to use Relay", which is apart of the free onboarding work being done.

l10n: mozilla-l10n/fx-private-relay-l10n#163

This PR is currently blocked due to a failing test which requires the string "Learn to use Relay" to be translated into german. Once this is done, we can merge this PR.

Screenshot (if applicable)

image

How to test

Checklist (Definition of Done)

  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • I've added or updated relevant docs in the docs/ directory
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.
  • l10n changes have been submitted to the l10n repository, if any.

@rafeerahman rafeerahman added the blocked Issue is blocked from proceeding label Nov 9, 2023
@rafeerahman rafeerahman removed the blocked Issue is blocked from proceeding label Nov 28, 2023
@rafeerahman
Copy link
Contributor Author

Copy link
Contributor

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous test were failing due to strings not being translated but the latest l10n has the translations and the CI tests are passing. No pending translation file was added because the strings are already translated too.

LGTM

@say-yawn say-yawn added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit bede85b Nov 28, 2023
24 checks passed
@say-yawn say-yawn deleted the MPP-3579 branch November 28, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants