feat(udp): return borrowed Datagram on receive #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2024
mxinden
commented
Oct 17, 2024
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
There was a problem hiding this comment.
I'll defer to @larseggert on this part. As far as I can see, it's good.
Previously `recv_inner` would return `Datagram<Vec<u8>>`. In other words, it would allocate a new `Vec<u8>` for each UDP datagram payload. Now `recv_inner` reads into a provided buffer and returns `Datagram<&[u8]>`, i.e. it returns a view into the provided buffer without allocating.
Pass a long lived receive buffer to `neqo_udp::recv_inner`, receiving an iterator of `Datagram<&[u8]>`s pointing into that buffer, thus no longer allocating in UDP receive path.
mxinden
force-pushed
the
recv-no-alloc-transport
branch
from
abf73ac
to
9330563
Compare
mxinden
force-pushed
the
recv-no-alloc-udp
branch
from
0a39777
to
1030d1b
Compare
larseggert
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #2187 which is stacked on top of #2184.
Previously
recv_innerwould returnDatagram<Vec<u8>>. In other words, it would allocate a newVec<u8>for each UDP datagram payload.Now
recv_innerreads into a provided buffer and returnsDatagram<&[u8]>, i.e. it returns a view into the provided buffer without allocating.Extracted out of #2093.
Part of #1693.
Pull request stack: