Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue comparing bigint to string #1608

Closed
tonygermano opened this issue Sep 2, 2024 · 3 comments · May be fixed by #1611
Closed

Issue comparing bigint to string #1608

tonygermano opened this issue Sep 2, 2024 · 3 comments · May be fixed by #1611
Labels
bug Issues considered a bug Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec

Comments

@tonygermano
Copy link
Contributor 

9007199254740992n < "9007199254740993"

Expected: true
Actual: false
@p-bakker p-bakker added bug Issues considered a bug Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec labels Sep 2, 2024
@tonygermano
Copy link
Contributor Author

I have a PR coming for this, and I found there is a test262 test which already covers it.

@tonygermano tonygermano mentioned this issue Sep 5, 2024
Draft
@p-bakker p-bakker mentioned this issue Oct 5, 2024
Merged
rbri added a commit to HtmlUnit/rhino-development that referenced this issue Oct 5, 2024
@rbri
add tests for mozilla#1608
557ee56
@rbri
Copy link
Collaborator

rbri commented Oct 5, 2024

@p-bakker have added some tests in #1681 but it looks like this is already solved on the head. I think we can close this.

rbri added a commit that referenced this issue Oct 5, 2024
@rbri
add tests for #1608
4214dfd
@p-bakker
Copy link
Collaborator

p-bakker commented Oct 5, 2024

Closed as already fixed

@p-bakker p-bakker closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues considered a bug Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Symbol.prototype and other related Symbol and type coersion changes tonygermano/rhino
3 participants
@rbri @p-bakker @tonygermano