Fixed ScriptRuntime.toPrimitive() and use it for toXXX() (taken from #1611 done by @tonygermano) #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gbrail will rebase my P&R branch after this is merged because i have to sort out some conflicts regarding to symbol handling |
|
I did a quick review and this looks good to me |
rbri
force-pushed
the
more_toPrimitive_usage
branch
from
8d3f07d
to
40d0ce5
Compare
fix s stupid bug in the toPrimitive() implementation introduced in mozilla#1661
rbri
force-pushed
the
more_toPrimitive_usage
branch
from
40d0ce5
to
3ed7160
Compare
|
Will this one resolve #1608? |
Its already solved on head - see my comment in the issue and the related pr. |
|
The code looks good to me and it moves us closer enough to our goal so that I think we should merge it -- LMK if you all have any objections. |
|
Thanks, new one will arrive soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another carve out from #1661.
It contains
This fixes again a bunch of Test262 cases and should be still backward compatible.
I left the single steps as single commits to (hopefully) make the review simpler. But I think we should squash this on merge.
@gbrail @tonygermano @rPraml @p-bakker please have a look, it was a bit hard to do the backward compatibility in toPrimitive() - i'm only 99% sure that all this is correct...