Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: MappingItem.source can be null #411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikolay-borzov
Copy link

There is a check in the code

 this._wasm.withMappingCallback(
      mapping => {
        if (mapping.source !== null) {
          mapping.source = this._absoluteSources.at(mapping.source);

          if (mapping.name !== null) {
            mapping.name = this._names.at(mapping.name);
          }
        }
        if (this._computedColumnSpans && mapping.lastGeneratedColumn === null) {
          mapping.lastGeneratedColumn = Infinity;
        }

        aCallback.call(context, mapping);
      },

therefore source can be null

create-react-app main.*.chunk,js.map contains null source

@coveralls
Copy link

coveralls commented Nov 15, 2019

Pull Request Test Coverage Report for Build 577

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.713%

Totals Coverage Status
Change from base Build 576: 0.0%
Covered Lines: 2481
Relevant Lines: 2733

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 577

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.713%

Totals Coverage Status
Change from base Build 576: 0.0%
Covered Lines: 1654
Relevant Lines: 1822

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants