Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foldable xml #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

samuelsinayoko
Copy link

@samuelsinayoko samuelsinayoko commented Jul 14, 2020

Makes XML foldable a la display.JSON

single_display_xml_screenshot

See ipython/ipython#12415

@eseiver
Copy link
Collaborator

eseiver commented Sep 14, 2021

Hi @samuelsinayoko, thanks for the PR and apologies for the long delay in response! display_xml is something @mpacer and I threw together pretty quickly a while ago and I'm so glad it's been helpful to others.
Foldable xml is a great addition to the library, I have two questions/comments before this can be merged.

  1. Thank you for creating the pytest component, but when I'm running locally both tests are failing.

Screen Shot 2021-09-14 at 14 59 26

Test 1 has AssertionError and Test 2 has TypeError: tostring() got an unexpected keyword argument 'pretty_print'

  1. The expand parameter works as expected, but I was wondering about the displayed triangles for collapsing from your examples. When I ran it, I didn't have the triangle indicators. Is it because of an IPython plugin you're using?

Screen Shot 2021-09-14 at 15 01 02

I ask because for my particular use case, I wanted to display the xml fully expanded, but also without collapsed section markers. So in addition to the `expand` parameter, I might want something like a `expandable` param that would remove the folding quality entirely if desired.

Thank you again for your efforts here! ~Ellis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants