win32: follow Windows settings and update dark mode state #11473
Conversation
|
Tested on latest Win11, works as expected now, switching to white theme also works. |
I don't have much time during a week and it turned out there are few quirks to fix with regards to initial window position/size. That I need to fix first. This PR is indeed complete and ready for review. |
kasper93
force-pushed
the
win32_dark
branch
3 times, most recently
from
a01f620
to
681bc9c
Compare
Microsoft documented how to enable dark mode for title bar: https://learn.microsoft.com/windows/apps/desktop/modernize/apply-windows-themes https://learn.microsoft.com/windows/win32/api/dwmapi/ne-dwmapi-dwmwindowattribute Documentation says to set the DWMWA_USE_IMMERSIVE_DARK_MODE attribute to TRUE to honor dark mode for the window, FALSE to always use light mode. While in fact setting it to TRUE causes dark mode to be always enabled, regardless of the settings. Since it is quite unlikely that it will be fixed, just use UxTheme API to check if dark mode should be applied and while at it enable it fully. Ideally this function should only call the DwmSetWindowAttribute(), but it just doesn't work as documented. Fixes: mpv-player#6901
|
I wonder if currently it's difficult to add an option for users to use dark mode "auto" , "always" or "never"? |
It would be easy, but what is the usecase for that? mpv doesn't have any ui elements affected except title bar, which doesn't really make sense to not follow system settings. |
Given that the cplugin based menu implemented in the #5500 (comment) is also controlled by dark mode, we now have other UI elements affected by this, and there may be more in the future. It is time to add options to control the behavior of mpv's dark mode. |
Microsoft documented how to enable dark mode for title bar:
https://learn.microsoft.com/windows/apps/desktop/modernize/apply-windows-themes https://learn.microsoft.com/windows/win32/api/dwmapi/ne-dwmapi-dwmwindowattribute
Documentation says to set the DWMWA_USE_IMMERSIVE_DARK_MODE attribute to TRUE to honor dark mode for the window, FALSE to always use light mode. While in fact setting it to TRUE causes dark mode to be always enabled, regardless of the settings. Since it is quite unlikely that it will be fixed, just use UxTheme API to check if dark mode should be applied and while at it enable it fully. Ideally this function should only call the DwmSetWindowAttribute(), but it just doesn't work as documented.
Fixes: #6901