win32: add an option to change window affinity

[DeadSix27]

Add an option to control the mpv window's affinity. This will affect how it's displayed on the desktop and in system-level operations like taking screenshots.

[garoto]

Will this affect previous Windows versions like 7 or 8.1?

[DeadSix27]

Will this affect previous Windows versions like 7 or 8.1?

It's supported since Windows 7, however the option excludefromcapture will not work on anything below Windows 10, as per Windows' API:

Starting in Windows 10 Version 2004, WDA_EXCLUDEFROMCAPTURE is a supported value. Setting the display affinity to WDA_EXCLUDEFROMCAPTURE on previous version of Windows will behave as if WDA_MONITOR is applied.

WDA_MONITOR being: The window content is displayed only on a monitor. Everywhere else, the window appears with no content.

--
So on Windows 7 and 8 setting the option to excludefromcapture will be the same as setting it to monitor.

See https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-setwindowdisplayaffinity for more info.

[garoto]

:default: No change in default Windows behavior

"mpv window" I assume?

--window-affinity=<default|excludefromcapture|monitor>
excludefromcapture is only mentioned here. Is it the same as system in the option explanation?

Probably best to replace all occurrences of The window with mpv window, since "The window" is very ambiguous.

[DeadSix27]

EDIT: also added ability to change it at runtime now.

:default: No change in default Windows behavior

"mpv window" I assume?

--window-affinity=<default|excludefromcapture|monitor> excludefromcapture is only mentioned here. Is it the same as system in the option explanation?

Probably best to replace all occurrences of The window with mpv window, since "The window" is very ambiguous.

Fixed those mistakes in the doc. Originally I was referring to "the default windows(as in OS) behavior" to avoid repeating "mpv window" but this works too.

[DeadSix27]

i have nothing else to add, feel free to review.

[Traneptora]

Can you please squash this commits? It's much easier to review that way. Also you can always merge master in with git pull upstream master --rebase and it will rebase your own commits atop the existing ones from master.

[DeadSix27]

Can you please squash this commits? It's much easier to review that way. Also you can always merge master in with git pull upstream master --rebase and it will rebase your own commits atop the existing ones from master.

Hope I did it right.. never squashed commits.

[DeadSix27]

How can i fix the merge mistake? I'm using the github desktop app.

[Dudemanguy]

Easiest way imo is to make a new branch off of master, cherry-pick the commit you want, delete your old one, rename the new branch to the old one, and then force push that.

[DeadSix27]

Thanks, works now, I also added an #ifdef to m_sub_options for the affinity option.
Mind reviewing it fully now?

[Dudemanguy]

Small comments.

[Dudemanguy]

Can't test but LGTM.

[DeadSix27]

I only tested it on Windows11, I have no 10 or 7 Machine.
On Linux I just checked if the code hampers compiling, anything else shouldn't matter code wise.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32

[Dudemanguy]

Can you get rid of the merge commit?

Edit: Looks like the fit_border option snuck back in there somehow (just removed it).

[DeadSix27]

Cleaned it up, should be fine now I hope, I accidentally ran git reset on 1 of my other repos which gave me headache...