remove some legacy garbage #12436
Merged
remove some legacy garbage #12436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudemanguy
force-pushed
the
remove-some-legacy-garbage
branch
5 times, most recently
from
5266421
to
7c4f79d
Compare
sfan5
reviewed
Sep 20, 2023
Dudemanguy
force-pushed
the
remove-some-legacy-garbage
branch
from
1eb1c59
to
70b76d6
Compare
|
Do we need to remove |
|
It's used for |
Dudemanguy
force-pushed
the
remove-some-legacy-garbage
branch
2 times, most recently
from
7bf3332
to
94c8216
Compare
Deprecated in 6597998. 6 years is more than enough time.
We've got an ungodly amount of OPT_REPLACED and OPT_REMOVED sitting around in the code. This is harmless, but the vast majority of these are ancient. 26f4f18 is the last commit that touched the majority of these and of course that only changed how options were declared so all of this stuff was deprecated even before that. No use in keeping these, so just delete them all. As an aside, there was actually a cocoa_opts but it had only a single option which was replaced by something else and empty otherwise. So that entire thing was just simply removed. OPT_REPLACED/OPT_REMOVED declarations that were added in 0.35 or later were kept as is.
drop-frame-count and vo-drop-frame-count are ancient and have no reason to exist anymore. The other change is that support for writing to display-fps has been removed, and the property is strictly read-only now. 3a2dc8b is what deprecated it with a warning to users, so we can remove it without much trouble.
e9e93b4 added a warning about writing the same value to the playlist-pos property that in the future it would stop restarting playback. Instead, you should use the playlist-play-index command for that. Well go ahead and drop the old deprecated behavior now and do what wm4 wanted this to do: just ignore if the same value is written again.
A bit different from the OPT_REPLACED/OPT_REMOVED ones in that the options still possibly do something but they have a deprecation message. Most of these are old and have no real usage. The only potentially controversial ones are the removal of --oaffset and --ovoffset which were deprecated years ago and seemingly have no real replacement. There's a cryptic message about --audio-delay but who knows. The less encoding mode code we have, the better so just chuck it.
Easier to keep track of when we do want to remove it.
No wonder wm4 wanted to get rid of this. This option requires touching a bunch of crap in the core player code. --stream-record works perfectly fine and is a lot nicer so there's no need for this to exist anymore.
These were deprecated a long time ago and apparently didn't even work with lavfi filters. Go ahead and remove them and additionally clean up some code related to them. m_config_from_obj_desc_and_args becomes much simpler now and a couple of arguments can be completely removed.
f560437 deprecated this since the --drm-device path option was added as a replacement. Drop the card number selection logic.
Dudemanguy
force-pushed
the
remove-some-legacy-garbage
branch
from
94c8216
to
1e9bb45
Compare
|
I documented a few more things in |
haasn
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of stuff sitting in the code that is there for compatibility reasons. A lot of it is really, really old and there's no point in keeping around at this stage. So I went through and deleted a bunch of crap. Nothing too controversial I think. Anything older than 0.35 was what I used as the cutoff point.