miscellaneous cosmetic fixes #12438
Merged
miscellaneous cosmetic fixes #12438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traneptora
reviewed
Sep 20, 2023
Traneptora
reviewed
Sep 20, 2023
|
What does forward-declaring mp_log accomplish, exactly? |
"Declaration of [...] will not be visible outside of this function" is the clang warning, I think this is purely cosmetic since mp_log ends up being included anyway. |
haasn
reviewed
Sep 20, 2023
|
PR title is misleading, changing integer division to floating point division is NOT a cosmetic change. The integer truncation (i.e., rounding down) may have been an intentional feature of the original code. |
|
I'll drop the integer division changes for now and thoroughly test if they were intended or not. I'm pretty sure the sub one at least is a bug fix, but I'll do it in another PR later. |
Dudemanguy
reviewed
Sep 21, 2023
Also improve comment about the assumed PlayResX and PlayResY
Mostly cosmetic
Dudemanguy
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to silence clangd, but the sd_ass integer division is actually a bug fix for subtitles with unknown durations