audio: allow specifying pitch correction filter #12479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
Dudemanguy
reviewed
Sep 25, 2023
Currently, the `audio-pitch-correction` flag is a bool which automatically inserts "scaletempo2" when needed. This hard default doesn't allow any nice way to insert the "rubberband" filter instead. This commit plumbs a way to get the filter name to auto_filters, and changes `audio-pitch-correction` to accept <no|rubberband|scaletempo2|yes>. "yes" is kept to not break configs suddenly, and is aliased to scaletempo2.
llyyr
force-pushed
the
pitch-correction
branch
from
7fa1c1f
to
6650b11
Compare
|
I missed an incredibly obvious and simple solution. See comment on #12474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
audio-pitch-correctionflag is a bool which automatically inserts "scaletempo2" when needed. This hard default doesn't allow any nice way to insert the "rubberband" filter instead.This commit plumbs a way to get the filter name to auto_filters, and changes
audio-pitch-correctionto accept<no|rubberband|scaletempo2|yes>. "yes" is kept to not break configs suddenly, and is aliased to scaletempo2.