console.lua: scale with the window height #14114

guidocella · 2024-05-11T09:54:26Z

This makes console.lua consistent with the OSD, osc.lua and stats.lua. This reads --osd-scale-by-window so users don't have to configure vidscale in yet another script.

github-actions · 2024-05-11T10:08:53Z

Download the artifacts for this pull request:

Windows

macOS

na-na-hi · 2024-05-11T12:06:15Z

player/lua/console.lua

+        w = 720 * aspect
+    end
+
+    local scale = mp.get_property_native("display-hidpi-scale", 1) * opts.scale


OSD and other scripts don't scale contents with hidpi scale in either scaling modes, so it still behaves differently.

Do we remove it then?

I also removed scale since I don't understand its purpose.

scale is basically required for readability on a hidpi display for lower-resolution videos. Well for me at least.

I don't get why we have to be the only application to scale text with window height either and use --osd-scale-by-window=no. but both kasper and nanahi requested this.

You guys are moving the bar right now. Everything in mpv scales. OSD, OSC, stats, subtitles. Name one thing which does not scale... console. I requested this, because it makes sense in mpv context.

EDIT:

If it is undesirable behavior, we can add another option and make it disable by default.

tbh there could be an argument made for subtitles not scaling. But anyways, I don't see the advantage of this change. It's fine to have it as an option I guess, but to me it's just a strictly worse default imo

I think this scaling only makes sense to not break ASS subtitles and they are not affected by --sub-scale-by-window anyway (despite the docs stating "Like --sub-scale, this can break ASS subtitles."). I don't understand the advantage of scaling by default elsewhere.

Stay on topic please. If you don't like the defaults, lets take effort to make OSC and stats respect --osd-scale-by-window by default, then changing the default for everything consistently only needs to change the default for a single flag. This PR is a step towards that.

kasper93 · 2024-06-24T19:40:49Z

This reads --osd-scale-by-window so users don't have to configure vidscale in yet another script.

I think it will be hard to agree to change console.lua default scaling, so maybe vidscale is the way, after all?

I'm fine with connecting this to osd-scale-by-window, but it seems controversial change.

guidocella · 2024-06-24T20:00:14Z

There's no point in connecting it to --osd-scale-by-window if it won't follow its value by default since the whole point was not having to configure multiple scripts. However it is not ideal to keep using the inaccurate name vidscale since text also scales with black bars around videos and scaling is confusing enough as it is.

kasper93 · 2024-06-24T20:31:21Z

What do you propose then? I think this scaling should be configurable, but indeed --osd-scale-by-window seems not compatible.

guidocella · 2024-06-24T20:49:03Z

Just scale-with-window=<yes|no> would be good I think. "Scale with" is much more common than "scale by" in this context. But does anyone actually intend to scale the console with the window or are we adding this for the heck of it?

kasper93 · 2024-06-24T21:02:06Z

I don't know. I'm simple man, I see open PR, I ask question. If you feel we don't need it, we can close and forget about it.

guidocella · 2024-06-27T10:05:37Z

Closing then as I only opened this PR because you and nanahi requested it. I don't see why you would want the console to be unreadable in small windows.

guidocella · 2024-10-17T10:18:40Z

Reopened due to many users wanting to scale. It is off by default. There is no consensus on what the default should be.

na-na-hi · 2024-10-17T15:55:07Z

player/lua/console.lua

@@ -20,6 +20,7 @@ local opts = {
    font = "",
    font_size = 16,
    border_size = 1,
+    scale_with_window = false,


Can you add an auto option similar to other scripts? It can still default to no of course. Also for consistency reason the option name can be vidscale.

vidscale is inaccurate because it doesn't scale with the video but with window, and vidscale itself is inconsistent with "osd-scale-by-window" anyway. They should all have been called scale with window. I don't think we need to keep using the bad naming from osc and stats in other scripts.

kasper93 · 2024-10-26T23:52:59Z

@guidocella: We have to resolve this issue. Current select font size is unusable. I think good default would be something along the lines of --script-opt=console-scale_with_window=yes --script-opt=console-font_size=24. I know there is #14114 which is not conclusive, but the question was about console, we need to fix select. Even if it means we have different behavior for select if we cannot agree on making console font bigger as a whole. Note that current console is also not usable on high resolution screens

If this is set to yes or auto and --osd-scale-by-window is true, console scales with the window height like everything else in mpv. Defaults to auto.

guidocella · 2024-10-27T06:10:11Z

Changed the default to auto as "Scale the console with the window height, respecting --osd-scale-by-window" + "Do both" now has more votes then "Keep it as is" in the poll.

kasper93 · 2024-10-27T18:25:03Z

I still think the font is too small for select even with scaling. In my opinion we shouldn't aim for "console appearance" in select.

Make the console easier to read because the current default is too small. See for example mpv-player#14903 (reply in thread) or mpv-player#15036 (comment) or mpv-player#15145 (comment) or mpv-player#15031 (comment). This also prevents libass from decreasing performance by printing many lines.

kasper93

As evident from some comments listed in the commit message, the current state of the select (and console) feature is not very usable. This PR makes it more universal and scalable for different display resolutions. While we can adjust default values to better suit most users, it’s unlikely we can satisfy everyone. These changes, however, are a significant improvement over the current state. Let’s take this step forward, and we can continue to make improvements as we go.

na-na-hi reviewed May 11, 2024

View reviewed changes

guidocella force-pushed the console-vidscale branch from c7ed931 to 06ae3fb Compare May 11, 2024 12:25

kasper93 approved these changes May 11, 2024

View reviewed changes

guidocella force-pushed the console-vidscale branch 5 times, most recently from 8187ebf to e948a0d Compare May 12, 2024 18:10

kasper93 mentioned this pull request May 17, 2024

{stats,osc}.lua: respect --osd-scale-by-window by default #14158

Merged

guidocella force-pushed the console-vidscale branch from e948a0d to 53bcc46 Compare May 20, 2024 16:38

guidocella force-pushed the console-vidscale branch from 53bcc46 to 117a8b3 Compare June 24, 2024 19:58

guidocella closed this Jun 27, 2024

guidocella mentioned this pull request Oct 12, 2024

stats.lua: rename a variable #15068

Merged

guidocella reopened this Oct 17, 2024

guidocella force-pushed the console-vidscale branch from 117a8b3 to c5f8e0f Compare October 17, 2024 10:17

guidocella force-pushed the console-vidscale branch from c5f8e0f to 89c48d1 Compare October 17, 2024 10:19

na-na-hi reviewed Oct 17, 2024

View reviewed changes

guidocella force-pushed the console-vidscale branch 2 times, most recently from 6a6b2b7 to d7764f0 Compare October 17, 2024 16:09

console.lua: add scale_with_window script-opt

43d5612

If this is set to yes or auto and --osd-scale-by-window is true, console scales with the window height like everything else in mpv. Defaults to auto.

guidocella force-pushed the console-vidscale branch from d7764f0 to 43d5612 Compare October 27, 2024 06:09

kasper93 approved these changes Oct 27, 2024

View reviewed changes

kasper93 merged commit d2fd394 into mpv-player:master Oct 27, 2024
26 checks passed

guidocella deleted the console-vidscale branch October 27, 2024 20:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

console.lua: scale with the window height #14114

console.lua: scale with the window height #14114

guidocella commented May 11, 2024

github-actions bot commented May 11, 2024 •

edited

Loading

na-na-hi May 11, 2024

guidocella May 11, 2024

na-na-hi May 11, 2024

guidocella May 11, 2024

Dudemanguy May 11, 2024

guidocella May 11, 2024

kasper93 May 11, 2024 •

edited

Loading

Dudemanguy May 11, 2024

guidocella May 11, 2024

na-na-hi May 11, 2024 •

edited

Loading

kasper93 commented Jun 24, 2024

guidocella commented Jun 24, 2024

kasper93 commented Jun 24, 2024

guidocella commented Jun 24, 2024

kasper93 commented Jun 24, 2024

guidocella commented Jun 27, 2024

guidocella commented Oct 17, 2024

na-na-hi Oct 17, 2024 •

edited

Loading

guidocella Oct 17, 2024

kasper93 commented Oct 26, 2024 •

edited

Loading

guidocella commented Oct 27, 2024 •

edited

Loading

kasper93 commented Oct 27, 2024 •

edited

Loading

kasper93 left a comment

console.lua: scale with the window height #14114

console.lua: scale with the window height #14114

Conversation

guidocella commented May 11, 2024

github-actions bot commented May 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kasper93 May 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

na-na-hi May 11, 2024 • edited Loading

Choose a reason for hiding this comment

kasper93 commented Jun 24, 2024

guidocella commented Jun 24, 2024

kasper93 commented Jun 24, 2024

guidocella commented Jun 24, 2024

kasper93 commented Jun 24, 2024

guidocella commented Jun 27, 2024

guidocella commented Oct 17, 2024

na-na-hi Oct 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kasper93 commented Oct 26, 2024 • edited Loading

guidocella commented Oct 27, 2024 • edited Loading

kasper93 commented Oct 27, 2024 • edited Loading

kasper93 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 11, 2024 •

edited

Loading

kasper93 May 11, 2024 •

edited

Loading

na-na-hi May 11, 2024 •

edited

Loading

na-na-hi Oct 17, 2024 •

edited

Loading

kasper93 commented Oct 26, 2024 •

edited

Loading

guidocella commented Oct 27, 2024 •

edited

Loading

kasper93 commented Oct 27, 2024 •

edited

Loading