-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github/workflows: add editorconfig linting #15135
Conversation
Download the artifacts for this pull request: |
cb1b453
to
095976f
Compare
seems like the |
84403e8
to
7da2814
Compare
instead of the setup-go action we could also just call had to exclude the |
Is this maybe equivalent to EDIT: If install works without setup-go, it should already have GOBIN defined IIRC. So we can try to call directly. |
sadly |
alternative [edit] |
looks good, we can use that. |
3fb54ae
to
e1e6b52
Compare
alternative or additional to #15132
follow up of #15124
IndentSize
disabled because it checks all indentation for multiple of indent_size, so spaces for alignment error too.MaxLineLength
disabled because we don't have a hard limit on 80, many/some files also go over 100, disabled in other linters too.excluding
osdep/dirent-win.h
since it's a straight copy and we decided to keep it as is.this checks all files like defined in our
.editorconfig
and not just c-family files like clang-format(?).in the upcoming release (3.1) they deprecated the
.ecrc
file in favour of the newly added.editorconfig-checker.json
. so i decided to use the new one instead (it's not auto discovered yet with the current version). the upcoming release will also addgithub-actions
formatting, so errors will also be displayed in the code/diff view of the PR similar to the swift linting. added this to the config file already, it is ignored with the current version.will fix the two remaining errors either here, if we decide to go with this, or in a separate PR.
@kasper93 i hope you don't mind this.