input: fix keybind command #15236
Merged
input: fix keybind command #15236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's just a copypaste of bind_keys with some params set to hard coded values, so use bind_keys instead.
kasper93
reviewed
Nov 1, 2024
kasper93
reviewed
Nov 1, 2024
kasper93
reviewed
Nov 1, 2024
|
Nice PR. |
|
Download the artifacts for this pull request: |
It's "cmd" rather than "command".
This allows the keybind to have a comment field which can be read from input-bindings, and displayed by e.g. stats.lua.
The command is documented to use the same syntax as input.conf, but it doesn't work with sequence keys because it uses mp_input_get_key_from_name for checking key names, when it should use mp_input_get_keys_from_string instead. Fix this by using the correct function.
na-na-hi
force-pushed
the
input-keybind-fix
branch
from
1d62ea3
to
1b85ef2
Compare
kasper93
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various issues with the
keybindcommand.