command: print circles at the beginning of lines in chapter-list #15283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timestamps don't have equal width in proportional fonts, so circles and titles are misaligned. By placing circles first at least the circles are aligned.
|
Download the artifacts for this pull request: |
|
Why are circles used for chapters, and not highlight like select.lua? |
|
Because nobody added it. To add color highlighting we would have to add options to make the style configurable in ASS and in the terminal and ensure it's still usable with color blindness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamps don't have equal width in proportional fonts, so circles and titles are misaligned. By placing circles first at least the circles are aligned.
Before:
After:
