Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build umd react-is process.env using replace plugin #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmfrancois
Copy link

Following #103 I propose here to follow the proposal of @TrySound
so you can choose:

replace plugin
2.7K hoist-non-react-statics.cjs.js
 15K hoist-non-react-statics.js
3.4K hoist-non-react-statics.min.js

without react-is from #103
2.7K  hoist-non-react-statics.cjs.js
3.3K hoist-non-react-statics.js
1.2K hoist-non-react-statics.min.js

@jmfrancois jmfrancois changed the title fix: build umd react-is process.env fix: build umd react-is process.env using replace plugin Nov 24, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.05% when pulling d96328f on jmfrancois:jmfrancois/fix/umd-replace into f3de655 on mridgway:master.

@alippai
Copy link

alippai commented Jul 1, 2021

While it's useful for development, I don't think a library should leak proptypes and react-is at all, it should be removed upon publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants