Run a check of the squid configuration before deploying it

[ndf-dw]

Run a check of the squid configuration before deploying it (and before restarting squid with a faulty configuration)

Description

When restarting squid service, squid will resolve all domain provided in configuration.
If a DNS entry does not exists, squid doesn't restart properly (it stops, and never start because of a faulty configuration).
This patch create a temporary configuration file, and run a check of this temporary configuration file.
If the check is OK, it will simply deploy the new configuration as it used to do.
If the check is KO, ansible will stop the playbook before modifying configuration on server (and before restating squid)

Related Issue

No related issue (except loosing squid service in production! :-/)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[mrlesmithjr]

@ndf-dw this is a great thing to add but it doesn’t appear to cleanup the staged file to validate?

[ndf-dw]

@ndf-dw this is a great thing to add but it doesn’t appear to cleanup the staged file to validate?

I added a task to cleanup after the check (it won't do the cleanup in case of check failure (but clean will be done once check is ok again))