-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pre-commit hooks and use of ruff #248
Improve pre-commit hooks and use of ruff #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about Ruff.
update makefile add make command for ruff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, we can merge it after resolving conflicts. @fpgmaas fyi
@SemyonSinchenko Thanks! Resolved conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one more comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fpgmaas Thanks for the contribution! |
0d47136
into
mrpowers-io:planning-1.0-release
Proposed changes
Currently, there are some issues with the use of pre-commit hooks and ruff:
>=0.5
inpyproject.toml
0.0.291
in.pre-commit-config.yaml
0.5.1
inci/lint.yaml
ruff format
is not part of the pre-commit hooks. The codebase currently contains unformatted code.pre-commit
is missing as a development dependencyThis PR proposes to;
ruff
, in the pre-commit hooks.ruff format
as part of the pre-commit hooks.