Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ruff versions and apply hotfix #251

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

fpgmaas
Copy link

@fpgmaas fpgmaas commented Jul 15, 2024

Proposed changes

This PR outlines some issues with the use of ruff and provides a solution. However, since that proposes a slightly larger overhaul and might need some discussion and tweaking, this PR proposes to align the versions of ruff specified in the various files. Also, it applies a hotfix to quinn/schema_helpers.py.

Types of changes

What types of changes does your code introduce to quinn?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@fpgmaas fpgmaas changed the title Hotfix Align ruff versions and apply hotfix Jul 15, 2024
@fpgmaas fpgmaas mentioned this pull request Jul 15, 2024
3 tasks
@SemyonSinchenko
Copy link
Collaborator

Let's wait until #244 is merged? Otherwise we will have a merge-conflicts again. Sorry about that: I love productivity, but I was not ready for such active development and too many PRs in the last days...

@fpgmaas
Copy link
Author

fpgmaas commented Jul 15, 2024

Let's wait until #244 is merged? Otherwise we will have a merge-conflicts again. Sorry about that: I love productivity, but I was not ready for such active development and too many PRs in the last days...

Sure, no problem! I will pause my PR's for a bit. Let me know when you're ready for new PR's.

@SemyonSinchenko
Copy link
Collaborator

@fpgmaas If you resolve the conflicts, I will merge this one. And after that we may merge #248

apply hotfix

update lock file
@fpgmaas
Copy link
Author

fpgmaas commented Jul 15, 2024

@SemyonSinchenko rebased :)

@SemyonSinchenko SemyonSinchenko merged commit a5c80cf into mrpowers-io:planning-1.0-release Jul 15, 2024
4 checks passed
@fpgmaas fpgmaas deleted the hotfix branch July 15, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants