Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linting from Makefile #259

Conversation

kunaljubce
Copy link
Contributor

Proposed changes

When trying to rebuild my local quinn dev env from the planning-1.0-release Makefile & pyproject.toml, there's a problem -

λ git kunaljubce/add-decorators-for-functions-r1.0 → make install_deps 

Group(s) not found: linting (via --with)
make: *** [install_deps] Error 1

Problem is with @poetry install --with=development,linting,testing,docs in Makefile and there NOT being any dependency group named linting in the project.toml.

Types of changes

What types of changes does your code introduce to quinn?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for that!

@SemyonSinchenko SemyonSinchenko merged commit caed478 into mrpowers-io:planning-1.0-release Sep 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants