-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the automated release process using googleapis/release-please #262
base: planning-1.0-release
Are you sure you want to change the base?
Conversation
* **release-please-config.json**: Add configuration file with release type set to `python`, changelog path to `CHANGELOG.md`, and packages to include `quinn`. * **.release-please-manifest.json**: Add manifest file with `quinn` version set to `1.0.0`. * **.github/workflows/release-please.yml**: Add workflow file for release-please action * **CONTRIBUTING.md**: Add a section for the "Release Process"
@nijanthanvijayakumar @SemyonSinchenko . It should be on So lets say u have window for releasing, and by that time u made 3 bug fixes added 2 new features, release please keeps all of those changes in your automatic pull request. Once u are ready to merge that automatic pull request created by release please, it would create a Github Release, bump versions in What release please lacks is using both prelease and release, it promotes trunk based, but it somehow does not allow it to use both of these. So u can automatically create for example release candidates, and then just have a manual workflow to release production version or vice versa. And ideally u tested this on separate github repo to make sure its all good. Also release-please-manifest.json, is what is used to track versioning under the hood, so current latest version should be there. |
@nijanthanvijayakumar @dinjazelena Thanks for the explanation! Do I understand right, that this workflow make a realease to PyPI? If so, which secrets should be provided? |
@SemyonSinchenko - this workflow creates a GitHub release as in the screenshot below and I don't think it creates a PyPi release (I might take your help in double-confirming this @dinjazelena?). The only reference to Python I used in this workflow is here. While creating it, I didn't see any references to PyPi and it worked on the test repo I shared earlier without involving the creation of any secrets. |
Can we somehow add a step to the release pipeline that publish in PyPI release or pre-release versions? |
Sure can look into it, but did you want that to be done in this PR? |
Yeah, so this only creates Github Release, but logically, u would just have additional step in your github action workflow with smth like this if: ${{ steps.release.outputs.release_created }}
run: |
poetry publish ... Here is an example for nmp. Question is only do you want to create automatic release for pre-releases or for production releases because unfortunately it cannot support both. |
I would have better automated prod-release |
@SemyonSinchenko - sure. I came across this article, and according to this, one doesn't need secrets to publish to the PyPI repository due to the "trusted publishing" feature. However, as indicated in the image below from the Set up PyPI publishing using GitHub section of that article, Quinn's project author or maintainer must add GitHub Actions as a trusted publisher for that project. Are you or @MrPowers able to do that while I whip up the code for publishing the package to PyPI? Steps for adding a trusted publisher is documented in this PyPI docs here - https://docs.pypi.org/trusted-publishers/adding-a-publisher/ |
Hello @SemyonSinchenko ! Any suggestions on the next steps? |
Sorry, I missed the comment. I will ask @MrPowers |
Thanks @SemyonSinchenko |
@nijanthanvijayakumar Do I understand you right that all the work is done and the only thing left is adding a trusted publihser to PyPI? |
Yep, @SemyonSinchenko - here's the commit that contains the changes that help publishing the code to the PyPI. |
@nijanthanvijayakumar LGTM overall, thanks for the effort and especially for the patience! |
But maybe u should guys use much more simpler way, i know i recommended this release please. What do u think about this approach. And all of that can be done via: It requires few clicks more, like taking care of version number and tag. |
@SemyonSinchenko @MrPowers I actually Prefer this method mentioned above which I sometimes call semi-automatic release over fully automatic prod release. It's simpler, safer and easier to manage. Whoever want to use the nonstable version of the product can always pull the snapshot |
Proposed changes
python
, and the changelog path toCHANGELOG.md
.quinn
version set to0.10.3
.Types of changes
What types of changes does your code introduce to quinn?
Put an
x
in the boxes that applyFurther comments
*CONTRIBUTING.md*
file to understand how this works. It took a bit of time to test the scenarios and understand how the release & pre-release works.