Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append schema functionality for review & comments. #86

Merged
merged 6 commits into from
Apr 8, 2023

Conversation

puneetsharma04
Copy link
Contributor

@puneetsharma04 puneetsharma04 commented Mar 18, 2023

Code changes in order to fix the review comments.

quinn/append_if_schema_identical.py Outdated Show resolved Hide resolved
quinn/append_if_schema_identical.py Outdated Show resolved Hide resolved
quinn/append_if_schema_identical.py Outdated Show resolved Hide resolved
quinn/__init__.py Outdated Show resolved Hide resolved
quinn/append_if_schema_identical.py Outdated Show resolved Hide resolved
@SemyonSinchenko SemyonSinchenko linked an issue Apr 1, 2023 that may be closed by this pull request
@puneetsharma04
Copy link
Contributor Author

Made the changes to code as suggested.
@SemyonSinchenko : Please review the code again and let me know in case any other changes are required to logic.

@MrPowers MrPowers reopened this Apr 3, 2023
@MrPowers
Copy link
Collaborator

MrPowers commented Apr 3, 2023

@puneetsharma04 - thanks for making the suggested edits. Let's keep this pull request open till it's merged.

@SemyonSinchenko - can you take another look and let us know what you think? Thanks!

@SemyonSinchenko
Copy link
Collaborator

LGFM
@MrPowers Should we merge it?

@MrPowers
Copy link
Collaborator

MrPowers commented Apr 8, 2023

@puneetsharma04 - thanks for the contribution!

@MrPowers MrPowers merged commit 04571ef into mrpowers-io:main Apr 8, 2023
@puneetsharma04
Copy link
Contributor Author

@MrPowers & @SemyonSinchenko : Let me know in case if there is any other issue is open for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create some "schema safe append" functionality
3 participants