perf: change valgrind flow and usage

msclock · Oct 22, 2023 · b444017 · b444017
1 parent 4e53c96
commit b444017
Showing 1 changed file with 19 additions and 18 deletions.
diff --git a/cmake/test/Valgrind.cmake b/cmake/test/Valgrind.cmake
@@ -4,36 +4,37 @@ Configure valgrind to check memcheck on testsuit
 Note:
   This requires enable the testing.
 
+Example:
+
+  include(Valgrind)
+
 ]]
 include_guard(GLOBAL)
 
-find_program(
-  VALGRIND_COMMAND
-  NAMES valgrind
-  DOC "valgrind executable")
-
 set(USE_VALGRIND
     "--leak-check=full --gen-suppressions=all --track-origins=yes"
     CACHE STRING "use valgrind to check memory issues.")
 
-if(VALGRIND_COMMAND)
-  message(
-    STATUS
-      "Activate valgrind: ${VALGRIND_COMMAND}.
-      USE_VALGRIND default options: --leak-check=full --gen-suppressions=all --track-origins=yes
-      Options:
-        --show-leak-kinds=all - show all possible leak
-        --gen-suppressions=all - gen suppress info automatically
-        --track-origins=yes - locates the original position
-        --suppressions=\"${CMAKE_SOURCE_DIR}/valgrind_suppress.txt\" - use valgrind suppress config file"
-  )
-endif()
+message(
+  STATUS
+    "Activate valgrind with USE_VALGRIND: ${USE_VALGRIND}
+  Options:
+    --show-leak-kinds=all - show all possible leak
+    --gen-suppressions=all - gen suppress info automatically
+    --track-origins=yes - locates the original position
+    --suppressions=\"\${CMAKE_SOURCE_DIR}/valgrind_suppress.txt\" - use valgrind suppress config file"
+)
 
-if(NOT CMAKE_HOST_UNIX)
+if(NOT CMAKE_HOST_UNIX OR NOT USE_VALGRIND)
   message(STATUS "Disable valgrind on non-unix system")
   return()
 endif()
 
+find_program(
+  VALGRIND_COMMAND
+  NAMES valgrind
+  DOC "valgrind executable")
+
 if(VALGRIND_COMMAND)
   set(VALGRIND_COMMAND_OPTIONS "${USE_VALGRIND}")
 else()