Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): Add Urdu language support #67

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Zaid-maker
Copy link

No description provided.

@Zaid-maker
Copy link
Author

Zaid-maker commented May 18, 2024

Idk why pnpm run translation:extract update all of the translation, that's why i had to revert everything!

@moonrailgun Hi! sorry for ping but i want to translate only one language the command translate all of the translation?? in the guide u say i need to set the env (which i did) and then run the command

@moonrailgun
Copy link
Contributor

Hi, @Zaid-maker . first thanks for your pr.

this command will extract all word which marked need to translate from source code.

free feel to submit others language's change if its auto generated by command. or you can only pick which you want to submit in git.

{
label: 'Urdu',
key: 'ur',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adhering to alphabetical order is a good choice

@moonrailgun
Copy link
Contributor

BTW, which flag should Urdu use?

@Zaid-maker
Copy link
Author

BTW, which flag should Urdu use?

Pakistan Flag

@Zaid-maker
Copy link
Author

Hi, @Zaid-maker . first thanks for your pr.

this command will extract all word which marked need to translate from source code.

free feel to submit others language's change if its auto generated by command. or you can only pick which you want to submit in git.

I got bit confused in the autogenerate thing can u help me out?

@Zaid-maker Zaid-maker closed this May 24, 2024
@moonrailgun
Copy link
Contributor

Hi, @Zaid-maker i am sorry for ignore this pr because a little busy recently, but why close this pr?

and for auto generate translation, i think we can follow this document.
image

but as you know, chatgpt is not perfect, if you can help me to improve it, i think its very cool

@Zaid-maker Zaid-maker reopened this May 28, 2024
@Zaid-maker
Copy link
Author

I did follow the Translation guide but not very convenient

@moonrailgun
Copy link
Contributor

ok this fine. can you tell me how about you think?

and if you have limited abilities, i can help you improve it after merge it. because i think now is ok, and we have same target is make tianji support more language.

@moonrailgun
Copy link
Contributor

Hi, i think this pr slate too much time, let me know if its ready for merge. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants