Skip to content

Commit

Permalink
Add golangci configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
mszostok committed Feb 5, 2019
1 parent c380632 commit 83a4571
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 4 deletions.
30 changes: 30 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
run:
deadline: 5m

linters:
disable-all: true
enable:
- dupl
- goconst
- gocyclo
- gofmt
- golint
- govet
- ineffassign
- interfacer
- lll
- misspell
- nakedret
- structcheck
- unparam
- varcheck

linters-settings:
dupl:
threshold: 400
lll:
line-length: 170
gocyclo:
min-complexity: 15
golint:
min-confidence: 0.85
5 changes: 1 addition & 4 deletions internal/check/valid_owner.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,8 @@ func (v *ValidOwnerChecker) initOrgListMembers(ctx context.Context) error {

func isEmailAddress(s string) bool {
_, err := mail.ParseAddress(s)
if err != nil {
return false
}

return true
return err == nil
}

func isGithubTeam(s string) bool {
Expand Down

0 comments on commit 83a4571

Please sign in to comment.