Cut off BaseMode workspace_dir extra call #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test |
Fixed by downgrading setuptools from 60.9.3 to 56.0.0, using |
carlosperate
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
The CI failure is only due to an issue with the very old Pi OS stretch configuration, so it can be ignored.
Code LGTM and manually tested locally as well 👍
Thanks @xbecas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplification of
mu/modes/base.pyby moving the logic of theget_default_workspace()function into the BaseMode.workspace_dir() method, as it was just redirecting to the above mentioned function.Note: first very simple PR on real code (not just translation files) to test the whole process!
PS: test
test_ButtonBar_add_actionfails, but was failing before the changes.