Fix asserts for called once in Python 3.12 #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosperate
force-pushed
the
python3.12
branch
from
e2c549a
to
757b1a7
Compare
|
Thanks for the PR @hrnciar, not sure why the tests didn't run, even if I changed the base branch (sometime that helps GitHub reset PRs). So I've rebased and pushed to your branch, and now it looks like the CI has been finally triggered. Once the tests pass we can merge the PR 👍 |
tests/test_logic.py
Outdated
| @@ -2524,7 +2524,7 @@ def test_change_mode_workspace_dir_exception(): | |||
| ed.change_mode("circuitpython") | |||
| assert mock_error.call_count == 1 | |||
| assert ed.mode == "circuitpython" | |||
| assert python_mode.workspace_dir.called_once() | |||
| python_mode.workspace_dir.assert_called_once() | |||
There was a problem hiding this comment.
Looks like assert_called_once() was introduced in Python 3.6, so it fails in 3.5.
We are about to update dependencies and drop support for all the legacy stuff, but in the meantime I'll update this to use assert_called_once_with() and it should pass tests.
carlosperate
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Okay, so the only CI failure is a known issue with the PiOS stretch environment, so this is good to be merged 👍
Thanks @hrnciar!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.12 the tests fail with:
AttributeError: 'called_once_with' is not a valid assertion. Use a spec for the mock if 'called_once_with' is meant to be an attribute.. Did you mean: 'assert_called_once_with'?While attempting to fix them we find out that the tests were not asserting anything in the past. This PR tries to solve it.