Fix test calling called_once_with() instead of assert_called_once_with().
#2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A MagicMock object was being asserted with 'called_once_with()' instead of 'assert_called_once_with()', likely an accidental mistake. As a MagicMock always returns another instance of MagicMock on anything not previoysly set up, the `assert` was always passing, even though we updated the Window.connect_zoom() implementation and that should have failed. In Python 3.12 this type of typo is caught and throws an exception.
carlosperate
changed the title
called_once_with() instead of assert_called_once_with().
carlosperate
commented
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A MagicMock object was being asserted with
called_once_with()instead ofassert_called_once_with(), likely an accidental mistake.As a MagicMock always returns another instance of MagicMock on anything not previoysly set up, the
assertwas always passing, even though we updated theWindow.connect_zoom()implementation and these asserts should be failing.I only noticed this because in Python 3.12 this type of typo is caught and throws an exception.