Audit focus states on disabled components #734
+2
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onehanddev
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
Netlify deploy preview |
onehanddev
changed the title
michaldudak
reviewed
Oct 23, 2024
| @@ -98,6 +98,7 @@ const CheckboxRoot = React.forwardRef(function CheckboxRoot( | |||
| extraProps: { | |||
| ...otherProps, | |||
| ...otherGroupProps, | |||
| disabled, | |||
There was a problem hiding this comment.
Instead of passing disabled here, it should be set by useCheckboxRoot's getButtonProps. You can remove aria-disabled and have just disabled prop returned from there.
Same with the Switch.
There was a problem hiding this comment.
Thank you for pointing that out! 🙏 I’ve updated the code.
Please let me know if there are any further changes needed. 😊
There was a problem hiding this comment.
It appears that removing aria-disabled is causing CircleCI’s browser tests to fail. I suspect this might be an accessibility (a11y) issue. Do you think we should reintroduce aria-disabled alongside the disabled prop?
…ove 'aria-disabled'. Applied the same update to Switch component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes -
[] I have followed (at least) the PR section of the contributing guide.