-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Add ref usage instructions on the Textarea page #39277
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting effort in to adding this to the docs! 🙌 Left a few copywriting and demo styling-related points there.
@luv2027 some tests are failing due to different reasons! I'd advise you to click on "Details" for each of them and see the instructions for how to fix it (they all should have some indication)! |
|
@luv2027 not sure either! But try fixing the others first, commit, and then see if this one persists! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for kickstarting the improvement! I adjusted the content a bit to focus on the textarea ref
instead of useRef
.
…added-Textarea-ref
Is there anything needs to be done to get pr merged ? |
…added-Textarea-ref
@siriwatknp the tests keep failing on this one, and it seems auth-related? Not sure how to solve them... mind taking a quick look? |
@luv2027 thanks for your work here! I ended up creating an identical PR as this because the checks kept failing due to some strange auth problem. Will close this one now but I appreciate your effort and please keep contributing! 😃 |
@danilo-leal Thank you so much for giving credits!! Hoping to contribute more often in this repo.. |
Fixes #39187
This PR adds a Textarea-ref in the Joy UI docs (/docs/joy/components/textarea/textarea.md).
It's usually more common to see textarea components using decorators at the top.
👉 https://deploy-preview-39277--material-ui.netlify.app/joy-ui/react-textarea/#textarea-ref