Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Add ref usage instructions on the Textarea page #39277

Closed
wants to merge 14 commits into from

Conversation

luv2027
Copy link

@luv2027 luv2027 commented Oct 3, 2023

Fixes #39187

This PR adds a Textarea-ref in the Joy UI docs (/docs/joy/components/textarea/textarea.md).
It's usually more common to see textarea components using decorators at the top.

👉 https://deploy-preview-39277--material-ui.netlify.app/joy-ui/react-textarea/#textarea-ref

@mui-bot
Copy link

mui-bot commented Oct 3, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 959ede7

@zannager zannager added the component: TextareaAutosize The React component. label Oct 3, 2023
@danilo-leal danilo-leal changed the title fix: added Textarea-ref in docs [docs][joy-ui] Add ref usage instructions on the Textarea page Oct 3, 2023
@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Oct 3, 2023
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting effort in to adding this to the docs! 🙌 Left a few copywriting and demo styling-related points there.

docs/data/joy/components/textarea/textarea.md Outdated Show resolved Hide resolved
docs/data/joy/components/textarea/textarea.md Outdated Show resolved Hide resolved
docs/data/joy/components/textarea/textarea.md Outdated Show resolved Hide resolved
docs/data/joy/components/textarea/TextareaRef.js Outdated Show resolved Hide resolved
docs/data/joy/components/textarea/TextareaRef.js Outdated Show resolved Hide resolved
@danilo-leal
Copy link
Contributor

@luv2027 some tests are failing due to different reasons! I'd advise you to click on "Details" for each of them and see the instructions for how to fix it (they all should have some indication)!

@luv2027
Copy link
Author

luv2027 commented Oct 4, 2023

@luv2027 some tests are failing due to different reasons! I'd advise you to click on "Details" for each of them and see the instructions for how to fix it (they all should have some indication)!

Screenshot 2023-10-04 201645
I am not able to get what is the real issue is ? I tried to do stack overflow but still I am not able to resolve the issue. Can you please help me figure it out ?

@danilo-leal
Copy link
Contributor

@luv2027 not sure either! But try fixing the others first, commit, and then see if this one persists!

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for kickstarting the improvement! I adjusted the content a bit to focus on the textarea ref instead of useRef.

@luv2027
Copy link
Author

luv2027 commented Oct 9, 2023

Is there anything needs to be done to get pr merged ?

@danilo-leal
Copy link
Contributor

@siriwatknp the tests keep failing on this one, and it seems auth-related? Not sure how to solve them... mind taking a quick look?

@danilo-leal
Copy link
Contributor

danilo-leal commented Oct 26, 2023

@luv2027 thanks for your work here! I ended up creating an identical PR as this because the checks kept failing due to some strange auth problem. Will close this one now but I appreciate your effort and please keep contributing! 😃

@luv2027
Copy link
Author

luv2027 commented Oct 26, 2023

@danilo-leal Thank you so much for giving credits!! Hoping to contribute more often in this repo..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: TextareaAutosize The React component. docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[joy-ui] How to access the ref of the <input>?
5 participants