Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input][base-ui] Update and port additional tests from material-ui #39584

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Oct 24, 2023

Part of: #38392
Follow up to: #38392 (comment)

This PR ports relevant tests from material-next/InputBase to Base's Input.test/useInput.test, as lot of functionality that was in the v5 InputBase has been migrated to Base UI.

@mj12albert mj12albert added test package: base-ui Specific to @mui/base component: input This is the name of the generic UI component, not the React module! labels Oct 24, 2023
@mui-bot
Copy link

mui-bot commented Oct 24, 2023

Netlify deploy preview

https://deploy-preview-39584--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 47cd5a4

@mj12albert mj12albert marked this pull request as ready for review October 24, 2023 09:17
@mj12albert mj12albert changed the title [Input][base-ui] Add tests [Input][base-ui] Update and port additional tests from material-ui Oct 24, 2023
@mj12albert mj12albert requested review from DiegoAndai, michelengelen and michaldudak and removed request for michelengelen October 24, 2023 09:23
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@mj12albert mj12albert merged commit 85afa7f into mui:master Oct 24, 2023
19 checks passed
@mj12albert mj12albert deleted the base/use-input-tests branch November 2, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: input This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants