Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Pagination] Update getItemAriaLabel page param type #43399

Merged
merged 3 commits into from
Aug 23, 2024
Merged

[material-ui][Pagination] Update getItemAriaLabel page param type #43399

merged 3 commits into from
Aug 23, 2024

Conversation

sydneyjodon-wk
Copy link
Contributor

This PR is to resolve #43385

@mui-bot
Copy link

mui-bot commented Aug 21, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43399--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 01ed6ab

@sai6855 sai6855 added typescript package: material-ui Specific to @mui/material component: pagination This is the name of the generic UI component, not the React module! labels Aug 22, 2024
@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review August 22, 2024 16:06
@sydneyjodon-wk sydneyjodon-wk mentioned this pull request Aug 22, 2024
Closed
@ZeeshanTamboli ZeeshanTamboli changed the title [mui-material][Pagination] Update getItemAriaLabel page param type [material-ui][Pagination] Update getItemAriaLabel page param type Aug 23, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Pagination] Update getItemAriaLabel page param type [material-ui][Pagination] Update getItemAriaLabel page param type Aug 23, 2024
siriwatknp
siriwatknp approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for working on this!

@siriwatknp siriwatknp merged commit 9f4b846 into mui:next Aug 23, 2024
22 checks passed
@sydneyjodon-wk sydneyjodon-wk deleted the update-pagination-getItemAriaLabel-type branch August 23, 2024 16:19
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 17, 2024
Open
@shagg0r shagg0r mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Merged
Merged
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 20, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 21, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Sep 22, 2024
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: pagination This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Pagination] getItemAriaLabel called with null page number contrary to type definition
5 participants
@sydneyjodon-wk @mui-bot @siriwatknp @sai6855 @ZeeshanTamboli