[button] Fix loading button regression #43400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
oliviertassinari
force-pushed
the
fix-loading-button-regression
branch
from
c4f6e25
to
a953e33
Compare
|
This is not working, repro steps:
|
|
Oh wow, it works in dev mode but fails in production mode. |
acrodemocide
approved these changes
Aug 23, 2024
|
It looks like there is no other workaround, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this in https://github.com/mui/mui-private/pull/511#issuecomment-2301378760, I didn't understand why we didn't go with: #27853 (comment), so I tested it and it seems to work. https://martijnhols.nl/gists/everything-about-google-translate-crashing-react go more in-depth into the problem.
It's a follow-up on #35198
Preview: https://deploy-preview-43400--material-ui.netlify.app/material-ui/react-button/#LoadingButtonsTransition