Update ResponsiveDrawer.js #44240
Open
Update ResponsiveDrawer.js #44240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this proposed change I use useMediaQuery and useTheme hooks to make the Drawer component responsive. I am using the Drawer component once instead of how it used twice in docs. I change the variant of the Drawer according to the screen width using the useMediaQuery and useTheme hooks. Just trying to implement it with the DRY principal. One drawer for both mobile and Desktop shown according to Device. If Desktop then the Drawer is permanent and if the Device is a mobile Device then the SAME Drawer is Temporary. Signed-off-by: MuiaAlex <[email protected]>
Netlify deploy previewhttps://deploy-preview-44240--material-ui.netlify.app/ Bundle size report |
zannager
added
the
component: drawer
oliviertassinari
added
the
PR: needs revision
There was a problem hiding this comment.
@AlexMuia31 Thanks for the pull request! The proposed idea looks good. Could you fix the CI and update the PR title? See the CONTRIBUTING guide for tips on creating a good PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this proposed change I use useMediaQuery and useTheme hooks to make the Drawer component responsive. I am using the Drawer component once instead of how it used twice in docs. I change the variant of the Drawer according to the screen width using the useMediaQuery and useTheme hooks. Just trying to implement it with the DRY principal. One drawer for both mobile and Desktop shown according to Device. If Desktop then the Drawer is permanent and if the Device is a mobile Device then the SAME Drawer is Temporary.