[react][core] Add support for sx replacement in transformed jsx calls #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
force-pushed
the
pigment/forward-sx-jsx
branch
from
ad9c475
to
7c61c06
Compare
mnajdova
approved these changes
Apr 19, 2024
|
@brijeshb42 what do you think about adding labels for each @pigment-css packages and add tags related to the packages. For example, I would title this PR: "[pigment-css-react][bug] Add support for sx replacements in transformed jsx calls" |
brijeshb42
force-pushed
the
pigment/forward-sx-jsx
branch
from
7c61c06
to
9b9f418
Compare
|
Makes sense regarding the tags. I'd maybe skip the |
brijeshb42
changed the title
|
That works too! |
|
@siriwatknp Let me know if this fixes your issues. I'll merge once you confirm. |
brijeshb42
force-pushed
the
pigment/forward-sx-jsx
branch
from
9b9f418
to
ce53f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got left out in the last PR where it only supported transformation in code with JSX.
This PR adds support for sx transform in already transformed JSX element to
jsx()calls.