New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unrar): extract_to should set parent path #50

Closed

deanrock wants to merge 1 commit into muja:master from deanrock:extract-to-directory

deanrock commented Apr 22, 2024 •

edited

Loading

It seems that just specifying the file does not work with absolute paths, e.g. /tmp/folder/filename.txt.

After doing some testing, it seems that providing parent folder as path and complete path as file is the only thing that consistently works.

I've also added tests, to ensure that both extraction to relative and absolute paths work as expected.


          fix(unrar): extract_to should set parent path

e77883e

muja closed this

muja reopened this

Owner

muja commented Aug 31, 2024

This is unnecessary and has already been fixed by the new UnrarDLL version. See #34 for more details

muja closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet