Fix clippy lints #60
Fix clippy lints #60
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faern)
nftnl/src/lib.rs line 120 at r6 (raw file):
/// /// The caller must pass a `buf` with enough space for the largest possible netlink message. /// This size can be obtained with `nft_nlmsg_maxsize()`.
A silly nit-pick, but maybe we could use proper doc-links, i.e. [`nft_nlmsg_maxsize`] instead of `nft_nlmsg_maxsize()`?
There was a problem hiding this comment.
Reviewable status: 4 of 6 files reviewed, all discussions resolved (waiting on @Serock3)
nftnl/src/lib.rs line 120 at r6 (raw file):
Previously, Serock3 (Sebastian Holmin) wrote…
A silly nit-pick, but maybe we could use proper doc-links, i.e. [`nft_nlmsg_maxsize`] instead of `nft_nlmsg_maxsize()`?
That's a small but nice improvement. Fixed!
There was a problem hiding this comment.
Reviewed 5 of 5 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, 1 of 1 files at r10, 1 of 1 files at r11, 1 of 1 files at r12, 1 of 1 files at r13, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Clippy had a thing or two to say about this crate. I noticed it in #57, but I decided to make a dedicated PR for it to keep the PRs more focused and smaller.
This change is