Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md with missing changes since last release #69

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Sep 19, 2024

This PR adds missing changelog items since the last release was made in preparation of a new release.


This change is Reviewable

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


CHANGELOG.md line 20 at r1 (raw file):

### Added
- Implement `Default` for `nftnl::batch::Batch`.
- Add support for Raw payload expressions: https://github.com/mullvad/nftnl-rs/pull/52.

We usually don't link to PRs, and you do it only for one out of many additional entries here. What is the motivation for that?

If we are going to reference PRs, my opinion is that #52 would be enough. Way shorter. I have seen that format in a bunch of changelogs, but I don't think I have seen people use the full URL.

Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faern)


CHANGELOG.md line 20 at r1 (raw file):

Previously, faern (Linus Färnstrand) wrote…

We usually don't link to PRs, and you do it only for one out of many additional entries here. What is the motivation for that?

If we are going to reference PRs, my opinion is that #52 would be enough. Way shorter. I have seen that format in a bunch of changelogs, but I don't think I have seen people use the full URL.

It was just for context, as I didn't think this changelog entry provided did that by itself. The link could very well be removed, not providing it would align stylistically with the rest of the changelog.

As for shortening the reference: It will be rendered as #52 in GitHub's markdown renderer, so it will looks nice & neat when browsing the changelog via GitHub. And I think providing the full link is more helpful for those who want to track the change.

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This fix could be mentioned, since it does fix a bug: e51fe76 Remove expect statments from nft_set macro

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it should be mentioned! Fixed

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @faern)

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 merged commit 562a55c into main Sep 19, 2024
2 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the update-changelog branch September 19, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants