Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move src to src dir #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: move src to src dir #10

wants to merge 1 commit into from

Conversation

olizilla
Copy link
Collaborator

Fixes inotify errors found in #7. The build process now only has to
watch the src dir rather than the whole project.

Brings external img refs inline so all the things are deployed to ipfs.

License: MIT
Signed-off-by: Oli Evans [email protected]

Fixes inotify errors found in #7. The build process now only has to
watch the src dir rather than the whole project.

Brings external img refs inline so all the things are deployed to ipfs.

License: MIT
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla requested a review from victorb July 16, 2018 08:30
@@ -10,8 +10,8 @@
</head>
<body class='sans-serif'>
<header class='pv3 ph2 ph3-l bg-navy cf'>
<a href="https://multiformats.io/" title='ipfs.io'>
<img src="https://ipfs.io/images/ipfs-logo.svg" class='v-mid' style='height:50px' />
<a href="https://ipfs.io/ipns/multiformats.io/" title='ipfs.io'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, is there a specific reason for linking to not the canonical version? IPNS tends to be a bit slower than just using DNS + IPFS hashes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know that... I'll change them back.

@hsanjuan
Copy link

@olizilla can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants