Change back the colors for speaking ... do nothing and whispering

[netinetwalker]

Please don't fuck up every User with the new colors on the default theme. But please make a theme variant availible for colorblind.

[netinetwalker]

I think it should be red for nothing and blue for activity

[mkrautz]

FWIW I actually liked the "old" colors for the new theme better myself -- so I have nothing against this Pr.

Also, @xpoke's commits that changed the colors were not meant to be final.
We're still looking for feedback.

But to say

Please don't fuck up every User with the new colors on the default theme
doesn't seem right to me.

The old default theme had
"Gray lips" -> not transmitting
"Red lips" -> transmitting (not only red, but you get the idea)

The new theme adds a non-gray color to the "not transmitting" state.

If anything, I would be more inclined to go for the colors from the "classic" Mumble theme instead...
They would probably also make more sense to long time users of Mumble.

[Sophira]

So I commented in mumble-voip/mumble#1858 with a mockup of a solution that I believe would work well for everybody, including colourblind users. Namely, having a muted blue for idle users, a saturated (but not too saturated) green for speaking users, and instead of a different colour for muted users, have their user icon and name show up at 50% alpha. In other words, something like this mockup that I made:

https://imgur.com/XgTvqc2

(The image was made by modifying a screenshot in the other thread. It's obviously slightly inaccurate since you wouldn't see anyone speaking in a room you weren't in, but I wanted to illustrate how it might look if you were in that room.)

Obviously, the muted blue would be different depending on whether the dark/light theme was used. It would be a good idea IMO to use opacity to do this.

I'm unfortunately not well-versed in Qt development so I'm not sure if I can do a pull request for this myself, but I could try if wanted.

[mkrautz]

@Sophira Looks good to me.

Regarding the muted blue: I know that @xpoke has been against making Dark/Lite specific changes.

The opacity change for muted users also seems nice.
I suppose it could also be used for a future "idle" state...

[Kissaki]

Just adding some overview info; This PR changes the images colors:

	before PR	after PR
inactive	green	red
active	blue	green
alt	yellow	blue