Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change categorical auto gray parameter to "auto", with warning #3460

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Sep 2, 2023

There's a longstanding quirk of the categorical plots where line/edge colors can be specified as "gray" which actually triggers an automatic computation of a gray value that complements the main colors in the plot. Since "gray" is a valid matplotlib color and it's not very obvious that this is happening, this PR migrates the behavior to "auto", with one release cycle of backwards compatibility and a FutureWarning.

sns.boxenplot(tips, x="total_bill", hue="time", linecolor="auto", palette="pastel", gap=.1)

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #3460 (7ce4da2) into master (ff446ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3460   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          75       75           
  Lines       24453    24460    +7     
=======================================
+ Hits        24045    24052    +7     
  Misses        408      408           
Files Changed Coverage Δ
seaborn/categorical.py 98.90% <100.00%> (+<0.01%) ⬆️
tests/test_categorical.py 99.13% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit e71d95b into master Sep 9, 2023
12 checks passed
@mwaskom mwaskom deleted the cat/auto_gray branch September 9, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant