Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize matplotlib kwargs in scatterplot / lineplot #3483

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Sep 18, 2023

Matplotlib 3.8 makes scatter raise when both long and short forms of arguments are passed (e.g. edgecolor and ec); previously one was silently ignored (I think?).

This is probably a marginal QOL improvement for matplotlib users but has broken the seaborn tests, as scatterplot sets a default edge color using the long-form argument but an example in the docs demonstrates the short-form example

This PR uses keyword argument normalization upstream of where seaborn sets its defaults. The whole situation is kind of a mess and this is just a localized bandaid, but it should get the tests green and marginally improve seaborn usability.

@mwaskom mwaskom added this to the v0.13.0 milestone Sep 18, 2023
@mwaskom mwaskom merged commit 1f78820 into master Sep 18, 2023
10 checks passed
@mwaskom mwaskom deleted the compat/scatter_kws branch September 18, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant