Normalize matplotlib kwargs in scatterplot / lineplot #3483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matplotlib 3.8 makes
scatter
raise when both long and short forms of arguments are passed (e.g.edgecolor
andec
); previously one was silently ignored (I think?).This is probably a marginal QOL improvement for matplotlib users but has broken the seaborn tests, as
scatterplot
sets a default edge color using the long-form argument but an example in the docs demonstrates the short-form exampleThis PR uses keyword argument normalization upstream of where seaborn sets its defaults. The whole situation is kind of a mess and this is just a localized bandaid, but it should get the tests green and marginally improve seaborn usability.