Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a matplotlib warning for strip/swarmplot with unfilled marker #3501

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Sep 26, 2023

We set edgecolor by default in these plots but matplotlib warns about that being ignored since we also have color. Not actually a problem for us, but better to avoid the non-actionable warning.

@mwaskom mwaskom added this to the v0.13.0 milestone Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #3501 (a0c73b2) into master (6b9e2fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3501   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          75       75           
  Lines       24592    24605   +13     
=======================================
+ Hits        24184    24197   +13     
  Misses        408      408           
Files Coverage Δ
seaborn/categorical.py 98.90% <100.00%> (+<0.01%) ⬆️
tests/test_categorical.py 99.25% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit 4888797 into master Sep 27, 2023
12 checks passed
@mwaskom mwaskom deleted the fix/cat_scatter_unfilled branch September 27, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant