Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mark width for overlapping data (#3769) #3770

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maurosilber
Copy link

This could be a fix for #3769, where the bin width for overlapping histograms is smaller than the actual bin width.

It renames "space" to "width" in so.Hist's calculated properties, and only applies extra scaling to the default width.

A possibly unintended consecuence is that it changes the look for so.Bar(), so.Hist() which used to look like so.Bar(), so.Count():

import seaborn as sns
import seaborn.objects as so

penguins = sns.load_dataset("penguins").dropna()

(
    so.Plot(penguins, x="species")
    .add(so.Bar(), so.Hist(), label="Hist")
    .add(so.Bar(color="C1"), so.Count(), label="Count")
)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant