correct logic around secure s3 parameter - fixes #43

myENA · Jul 3, 2018 · 052e096 · 052e096
1 parent 2f3a34c
commit 052e096
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/common/s3util.go b/common/s3util.go
@@ -108,8 +108,11 @@ func parseS3URI(s3uri string) (*s3Info, error) {
 		if secure, err = strconv.ParseBool(temps); err != nil {
 			return nil, err
 		}
-		// update config
-		info.awsConfig.DisableSSL = aws.Bool(secure)
+		// update config to disable SSL if secure is false
+		// see #43 - this was a terrible name for this paramater
+		if secure == false {
+			info.awsConfig.DisableSSL = aws.Bool(true)
+		}
 	}
 
 	//check for pathstyle override