Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rn/upgrade 63 4 ios jsi #9

Open
wants to merge 8 commits into
base: rn/upgrade_63_4_ios
Choose a base branch
from

Conversation

nitish24p
Copy link
Collaborator

WHAT

Add thin JSI layer for fetching config via JS runtime.Everytime NSUSerdefaults get updated a message gets sent to notification center and the entire config gets sent to the NATIVE side via the Bridge. This ends up choking the bridge with a size of upto 600Kb everytime.

Old FLow

UI -> Set Key -> Update NS UserDefault -> Notify Observer -> Send Defaults Via bridge (600Kb)

NEW FLOW

UI -> Set Key -> Update NS UserDefault -> Notify Observer -> Send small message via bridge 100B -> Pull Config Via JSI

Perf Improvements.

Sizes are in KBs

Screenshot 2023-01-02 at 11 44 18 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant