Impression measurement config #1
Conversation
…ecking recyclerlist view item impression
| const timeoutId = setTimeout(() => { | ||
| that.timers.delete(timeoutId); | ||
|
|
||
| const currAll = all.filter((index) => that._visibleIndexes.indexOf(index) >= 0); |
There was a problem hiding this comment.
What is the max array batch size of all: number[]
There was a problem hiding this comment.
all has all the list items that are visible in viewport at a time
So it depends on list items sizes
| @@ -181,7 +188,7 @@ export default class RecyclerListView<P extends RecyclerListViewProps, S extends | |||
| this._pendingScrollToOffset = offset; | |||
| }, (index) => { | |||
| return this.props.dataProvider.getStableId(index); | |||
| }, !props.disableRecycling); | |||
| }, !props.disableRecycling, props.viewabilityConfig); | |||
There was a problem hiding this comment.
viewabilityConfig is just initialized in the constructor any changes to viewabilityConfig after the first render will not be respected.
This use case would come for pagination later with multiple impression configs at the widget level.
| let visibleItemContent = 0; | ||
| const itemSize = itemEndBound - itemStartBound; | ||
|
|
||
| if (window.start >= itemStartBound && window.end >= itemEndBound) { |
There was a problem hiding this comment.
can you add some comments explaining the if-else with some examples
src/core/ViewabilityTracker.ts
Outdated
| if (func) { | ||
| const now = this._calculateArrayDiff(newItems, oldItems); | ||
| const notNow = this._calculateArrayDiff(oldItems, newItems); | ||
| if (now.length > 0 || notNow.length > 0) { | ||
| func([...newItems], now, notNow); | ||
| // Adding default minimum view time of 250ms for performance optimization | ||
| if (minimumViewTime && minimumViewTime >= Constants.DEFAULT_MIN_VIEW_TIME) { |
There was a problem hiding this comment.
instead of not executing the minimumViewTime logic incase of DEFAULT_MIN_VIEW_TIME greater than minimumViewTime you could execute with minimumViewTime logic with default value.
Reset viewability tracker
Revert "Reset viewability tracker"
Reset viewability tracker
fixed version for @types/resize-observer-browser removed ^
Adding viewability config to add support for minimum item view time and minimum item view percentage.